This repository was archived by the owner on Dec 16, 2022. It is now read-only.
Conversation
Signed-off-by: GuptaManan100 <manan@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
split ast_helper into individual gen files
…lock [vtadmin] vtexplain lock
…erent shards in a stream Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Adds support for ordering on character fields for sharded keyspace queries
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Hormoz K <hkheradm@gmail.com>
Signed-off-by: Hormoz K <hkheradm@gmail.com>
show columns query on system schema
Signed-off-by: Hormoz K <hkheradm@gmail.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Hormoz K <hkheradm@gmail.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Fuzzing: Add new mysql fuzzer
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Make vttestserver compatible with persistent data directories
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: GuptaManan100 <manan@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Merge release 8.0 into 9.0
…ess-v10.pre Signed-off-by: Andrew Mason <amason@slack-corp.com>
Version 10.0.2 Signed-off-by: Andrew Mason <amason@slack-corp.com>
Here's why: ``` ❯ go mod why github.com/moby/term vitess.io/vitess/go/vt/vttablet/onlineddl github.com/skeema/tengo github.com/fsouza/go-dockerclient github.com/docker/docker/pkg/jsonmessage github.com/moby/term ``` Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
git seemed to not apply this change after the formatting functions got moved from `ast.go` to `ast_format.go` Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
ajm188
force-pushed
the
am_slack-vitess-v10.pre
branch
from
7a88f44 to
767d29c
Compare
added 3 commits
July 18, 2021 19:50
Done via `git checkout v10.0.2 -- "${test_file}"`
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
ajm188
force-pushed
the
am_slack-vitess-v10.pre
branch
from
a6bd346 to
be9097a
Compare
added 2 commits
July 18, 2021 21:10
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Author
|
Looks like we're missing these changes: |
DDL bypass plan Signed-off-by: Andrew Mason <amason@slack-corp.com>
ajm188
force-pushed
the
am_slack-vitess-v10.pre
branch
from
6aa7a4c to
3a388ab
Compare
Signed-off-by: Andrew Mason <amason@slack-corp.com>
ajm188
force-pushed
the
am_slack-vitess-v10.pre
branch
from
3a388ab to
c7e92dc
Compare
guidoiaquinti
approved these changes
Jul 20, 2021
guidoiaquinti
left a comment
guidoiaquinti
left a comment
There was a problem hiding this comment.
LGTM, but we really need to improve this process.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
19 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some notes about these commits:
git log --reverse --merges master...HEAD. I'm calling out any of the PRs that I think fit that description.vttablet
xtrabackup_root_pathto find xbstream (use provided xtrabackup_root_path to find xbstream vitessio/vitess#7359)SETstatements using the passed in bindvars (Fix Set Statement in Tablet when executed with bindvars vitessio/vitess#7431)information_schema_stats_expiryto allowed list of set vars (added information_schema_stats_expiry to allowed list of set vars vitessio/vitess#7435)gh-ostbinary to v1.1.1 (OnlineDDL: update gh-ost binary to v1.1.1 vitessio/vitess#7394). Notable changes ingh-ost:AUTO_INCREMENTvalue from original table - Copying AUTO_INCREMENT value to ghost table openark/gh-ost#12GENERATEDcolumns inPRIMARY KEY(or in any unique key) - Generated column as part of UNIQUE (or PRIMARY) KEY openark/gh-ost#13PreHandleFuncto mysql listener for adding custom TLS termination (mysql/server: add PreHandleFunc hook for connections vitessio/vitess#7513)caching_sha2_passwordplugin in mysql client (Support for caching_sha2_password plugin in mysql/client vitessio/vitess#6716)innodb_read_rowsas vttablet metric (Add innodb_read_rows as vttablet metric vitessio/vitess#7520)eta_secondsin OnlineDDL (Online DDL: internal support for eta_seconds vitessio/vitess#7630)-disable_active_reparentsin backup/restore (Respect -disable_active_reparents in backup/restore vitessio/vitess#7576)SELECT WITH LOCKto passthrough in vttablet (Allow Select with lock to pass through in vttablet vitessio/vitess#7584)transaction_payload_event) (VReplication: error out if binlog compression is turned on vitessio/vitess#7670)filecustomrulemanagement (Implements CLI tool for rule management vitessio/vitess#7712)disable_active_reparentsbefore waiting for position update during restore (restore: check disable_active_reparents properly before waiting for position update vitessio/vitess#7703)numeric_precisionandnumeric_scalecolumns in information_schema (Tests for numeric_precision and numeric_scale columns in information_schema vitessio/vitess#7763)unhealthy_thresholdvia debugEnv ([10.0] Allow modification of tablet unhealthy_threshold via debugEnv vitessio/vitess#7938)xtrabackuperror when using mysql global variableold_alter_table(workaround xtrabackup error using mysql global variable old_alter_table vitessio/vitess#8340)vtgate
isIncludedproperly to include replica/rdonly tablets in other cells ([8.0] healthcheck: use isIncluded correctly to fix replica/rdonly routing bug vitessio/vitess#6922)show databases(this is now different from runningshow keyspaces) (added default databases when calling 'show databases' vitessio/vitess#7256)vitess_versionas a variable that can beselect-ed (added vitess_version as variable vitessio/vitess#7295)@@enable_system_settingsto vtgate (Addition of @@enable_system_settings to vtgate vitessio/vitess#7300)@@versionand@@version_commentto include vitess version info (Change @@version and @@version_comment vitessio/vitess#7337)DROP,CREATEandALTERdatabase commands (Fixes the error messages in drop, create and alter database commands vitessio/vitess#7397)information_schemaqueries when using system schema intable_schemacomparison (Fix information_schema query with system schema in table_schema filter vitessio/vitess#7430)RowsAffected(Add vtgate stats for RowsAffected similar to RowsReturned vitessio/vitess#7380)DESCto route based on table name and qualifier (Describe table to route based on table name and qualifier vitessio/vitess#7445)information_schemaqueries (Adds another case to merge routes for information_schema queries vitessio/vitess#7504)SHOWplans to consider default keyspace (Show anywhere plan fix to consider default keyspace vitessio/vitess#7531)@@socketsystem variable to return the socket path of the vtgate connection (Socket system variable to return vitess mysql socket vitessio/vitess#7637)SHOW VITESS_MIGRATIONSqueries (Online DDL: support 'SHOW VITESS_MIGRATIONS' queries vitessio/vitess#7638){CREATE, DROP} DATABASEpluggable (Make DROP/CREATE DATABASE pluggable vitessio/vitess#7381)FLUSHstatement planner (fix flush statement planner vitessio/vitess#7695)REVERT VITESS_MIGRATIONstatement support (Support for REVERT VITESS_MIGRATION statement vitessio/vitess#7656)ALTER VITESS_MIGRATIONqueries (Support for ALTER VITESS_MIGRATION statements vitessio/vitess#7663)show columnsquery on system schema (show columns query on system schema vitessio/vitess#7729)-enable_online_ddl_flag(VTGate: support -enable_online_ddl flag vitessio/vitess#7694)falsefor system settings to be changed per-session at the db-connection level (Default to false for system settings to be changed per session at the database connection level vitessio/vitess#7921)keyspaces_to_watchregression ([10.0] Fix for keyspaces_to_watch regression vitessio/vitess#7936PlannedReparentShard(Fix for transactions not allowed to finish during PlannedReparentShard vitessio/vitess#8099)vtctld
FindAllShardsInKeyspaceoutput ([vtctld] Fix accidentally-broken legacy vtctl output format vitessio/vitess#7285)Workflow AborttoWorkflow Cancel(Vreplication V2 Workflows: rename Abort to Cancel vitessio/vitess#7276)InitShardMasterto new vtctldserver asInitShardPrimary(Migratevtctlclient InitShardMaster=>vtctldclient InitShardPrimaryvitessio/vitess#7220)GetCellInfoNames,GetCellInfo,GetCellsAliases) to vtctldserver ([vtctld] Migrate cell getters vitessio/vitess#7302)GetTablet,{ListShardTablets, ListAllTablets, ListTablets} =>GetTablets`) to vtctldserver ([vtctld] migrate tablet getters vitessio/vitess#7311)MoveTables/Reshard StarttoCreateGetSrvVSchemato vtctldserver ([vtctld] Add GetSrvVSchema command vitessio/vitess#7334)GetSchemato vtctldserver ([vtctld] Migrate GetSchema vitessio/vitess#7346)Workflow show(Workflow Show: use timeUpdated to calculate vreplication lag vitessio/vitess#7342)ListBackupsasGetBackupsin vtctldserver ([vtctld] Migrate ListBackups as GetBackups in new vtctld server vitessio/vitess#7352)GetVSchemato vtctldserver ([vtctld] Migrate GetVSchema to VtctldServer vitessio/vitess#7360)InitShardPrimaryto use it (Add protoutil package, refactor ISP to use it vitessio/vitess#7421)maxReplPosSearchtopackage topotools(Extract themaxReplPosSearchstruct out totopotoolsvitessio/vitess#7420)ErrorGrouptopackage concurrency, use inwaitOnNMinusOneTabletsduring PlannedReparentShard (AddErrorGroupto package concurrency, use inwaitOnNMinusOneTabletsvitessio/vitess#7429)SilenceErrorson the root command, so we don't double-log vitessio/vitess#7404)EmergencyReparentShardlogic to dedicated struct and add tests ([vtctld/wrangler] ExtractEmergencyReparentShardlogic to dedicated struct and add unit tests vitessio/vitess#7464)EmergencyReparentShard- ensure at least one replica successfullySetMasteror fail ([reparentutil / ERS] confirm at least one replica succeeded toSetMaster, or fail vitessio/vitess#7486)PlannedReparentShardlogic to a dedicated struct with tests ([reparentutil / wrangler] Extract PlannedReparentShard logic from wrangler to PlannedReparenter struct vitessio/vitess#7501)EmergencyReparentShardto not WaitForRelayLogsToApply on primaries that were never running replication ([reparentutil] ERS should not attempt to WaitForRelayLogsToApply on primary tablets that were not running replication vitessio/vitess#7523)-cellsand-tablet_typesparameters to Materialize command (Materialize: Add cells and tablet_types parameters vitessio/vitess#7562)workflow/vexecpackages to vtctldserver ([vtctld] Add v0 GetWorkflows rpc and workflow/vexec packages vitessio/vitess#7575)-skip_prefilghtflag toApplySchema(ApplySchema: -skip_preflight vitessio/vitess#7587)GetSrvKeyspaceasGetSrvKeyspacesin vtctldserver ([vtctld] Migrate GetSrvKeyspace as GetSrvKeyspaces in VtctldServer vitessio/vitess#7680)EmergencyReparentShardfix local variable binding in goroutines ([reparentutil | ERS] Bind status variable to each goroutine in WaitForRelayLogsToApply vitessio/vitess#7692)ShardReplicationPositions([vtctld] Migrate ShardReplicationPositions vitessio/vitess#7690)List/Get Tablets([vtctl|vtctldserver] List/Get Tablets timeouts vitessio/vitess#7715)vtctl ApplySchemasupports-request_contextflag (vtctl ApplySchema supports '-request_context' flag vitessio/vitess#7777)ddl_strategy(vtctl: return error on invalid ddl_strategy vitessio/vitess#7924)SrvVSchemaafter an ExternalVindex vrep flow (ExternalizeVindex: refresh SrvVSchema after an ExternalizeVindex flow vitessio/vitess#8373)EmergencyReparentShardcases (Fix problematic ERS cases vitessio/vitess#8422)vtadmin
clusterfield to /api/gates response ([vtadmin-api] Addclusterfield to vtadmin-api's /api/gates response vitessio/vitess#7425)document.titlefrom route components (Throttler: fix to client usage in vreplication and table GC vitessio/vitess#7422)replaceQuery,pushQuerytouseURLQueryhook ([vtadmin-web] Add replaceQuery + pushQuery to useURLQuery hook vitessio/vitess#7507)grpcserver([vtadmin] Add support for additional service healthchecks in grpcserver vitessio/vitess#7635)optionsparameter to API hooks ([vtadmin-web] Add comments + 'options' parameter to API hooks vitessio/vitess#7754)max-widthto infra table views ([vtadmin-web] Add common max-width to infrastructure table views vitessio/vitess#7760)topo
GetSrvKeyspaceNames(fix hang when local topo was down vitessio/vitess#7278)vreplication
enumcolumns ([8.0] Backport 6880 vitessio/vitess#6925)binary()columns to match values returned by mysql selects (VReplication: Pad binlog values for binary() columns to match the value returned by mysql selects vitessio/vitess#8137)performance
-pprofflag (servenv: provide a global flag for profiling vitessio/vitess#7496)credentials
sqlparser
AddWheresupport for Update AST nodes, just like Select nodes (Add Update.AddWhere to mirror Select.AddWhere vitessio/vitess#7277)CREATE TABLEformatting to includeIF NOT EXISTScorrectly (fix create table format function to include if not exists vitessio/vitess#7250)CREATE TABLEparser (Added some unit test cases for CREATE TABLE parser vitessio/vitess#7279){TRUNCATE, RENAME, DROP INDEX, FLUSH}(Adds Planning and Parsing Support for Truncate, Rename, Drop Index and Flush vitessio/vitess#7242)CALLprocedure support (Support for CALL procedures vitessio/vitess#7287)ENFORCEDword so statements remain compatible with mysql5.7 (Removes printing of ENFORCED word so that statements remain compatible with mysql 5.7 vitessio/vitess#7458)SELECT ALL(add support for SELECT ALL vitessio/vitess#7593)SELECT INTO(Fixes ordering in SELECT INTO and printing of strings vitessio/vitess#7655)select current_user()(Fix MySQL Workbench failure on login withselect current_user()vitessio/vitess#7705)PRIMARYindex hint (PRIMARY in index hint list for release 10.0 vitessio/vitess#8159)CREATE TABLEto require parentheses (Fixes function call in default value of a column in CREATE TABLE statement vitessio/vitess#8425)orchestrator
orchestrator-msgparams (orchestrator: prevent XSS attack via 'orchestrator-msg' params vitessio/vitess#7526)build
docker buildmore robust (Make dependency install a bit more robust vitessio/vitess#7260)MYSQL_BIND_HOSTenvvar to vttestserver images (docker/vttestserver: Add MYSQL_BIND_HOST env vitessio/vitess#7293)VT_BASE_VERto vtexplain dockerfile (Add VT_BASE_VER to vtexplain/Dockerfile vitessio/vitess#7467)curlin vtctlclient docker image (docker vitess/vtctlclient: Install curl vitessio/vitess#7466)-mysql_server_versionin vttestserver, and utilize in container images (Enable -mysql_server_version in vttestserver, and utilize it in vttestserver container images vitessio/vitess#7474)percona-toolkitto docker/lite images (Add percona-toolkit (for pt-osc/pt-online-schema-change) to the docker/lite images vitessio/vitess#7603)makebuild static binaries by defaultci
go mod tidytest (CI: adding 'go mod tidy' test vitessio/vitess#7461)make sizegenwas run (Workflow to check make sizegen vitessio/vitess#7535)clusterListfrom string to array inci-workflow-gen(ci-workflow-gen: turn string to array to reduce conflicts vitessio/vitess#7582)misc
key.Destination.IsUnique()function (Remove unused key.Destination.IsUnique() vitessio/vitess#7565)Show Statusquery to vtexplain (Add Show Status query to vtexplain and make asthelpergen/sizegen quiet vitessio/vitess#7590)rowlogtool for vstream skew change (Backport 7809: Update rowlog for the API change made for the vstream skew alignment feature vitessio/vitess#7890)releasescript to makefile (Added release script to the makefile vitessio/vitess#8030)