Skip to content

[vtadmin-api] Add /api/clusters endpoint to vtadmin-api#7426

Merged
rohit-nayak-ps merged 1 commit intovitessio:masterfrom
tinyspeck:sarabee-vtadmin-api-clusters
Feb 1, 2021
Merged

[vtadmin-api] Add /api/clusters endpoint to vtadmin-api#7426
rohit-nayak-ps merged 1 commit intovitessio:masterfrom
tinyspeck:sarabee-vtadmin-api-clusters

Conversation

@doeg
Copy link
Contributor

@doeg doeg commented Feb 1, 2021

Signed-off-by: Sara Bee 855595+doeg@users.noreply.github.com

Description

Thrilling.

Response from http://localhost:14200/api/clusters, run against local Docker:

{"result":{"clusters":[{"id":"id1","name":"cluster1"}]},"ok":true}

Related Issue(s)

N/A

Checklist

  • Should this PR be backported?
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build/CI
  • VTAdmin

@doeg doeg requested review from ajm188 and rohit-nayak-ps February 1, 2021 17:19
Copy link
Contributor

@ajm188 ajm188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one very minor thing, otherwise lg2m

@doeg doeg force-pushed the sarabee-vtadmin-api-clusters branch from 965aa3c to 613fa70 Compare February 1, 2021 19:44
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
@doeg doeg force-pushed the sarabee-vtadmin-api-clusters branch from 613fa70 to e3088b4 Compare February 1, 2021 19:52
Copy link
Contributor

@ajm188 ajm188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg2m

@rohit-nayak-ps rohit-nayak-ps merged commit 0ffb8c1 into vitessio:master Feb 1, 2021
@askdba askdba added the Component: VTAdmin VTadmin interface label Feb 8, 2021
@askdba askdba added this to the v10.0 milestone Feb 8, 2021
@doeg doeg changed the title Add /api/clusters endpoint to vtadmin-api [vtadmin-api] Add /api/clusters endpoint to vtadmin-api Mar 16, 2021
@doeg doeg deleted the sarabee-vtadmin-api-clusters branch November 1, 2021 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: VTAdmin VTadmin interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants