Add option to log queries only when rows returned/affected >= X#7509
Merged
shlomi-noach merged 5 commits intovitessio:masterfrom Mar 3, 2021
Merged
Add option to log queries only when rows returned/affected >= X#7509shlomi-noach merged 5 commits intovitessio:masterfrom
shlomi-noach merged 5 commits intovitessio:masterfrom
Conversation
Signed-off-by: Jacques Grove <aquarapid@gmail.com>
certain number of rows. Redo of PR vitessio#5938, minimizing type changes this time. Signed-off-by: Jacques Grove <aquarapid@gmail.com>
aquarapid
requested review from
harshit-gangal,
shlomi-noach and
systay
as code owners
Member
|
Nice! I was actually going to implement something similar and add metrics as well. It could be nice to have a histogram for each digest displaying the query counts by What do you think about it? |
Contributor
Author
|
Yeah, that is somewhat more work. I won't take that on in this PR :-)
|
Signed-off-by: Jacques Grove <aquarapid@gmail.com>
Signed-off-by: Jacques Grove <aquarapid@gmail.com>
shlomi-noach
approved these changes
Mar 3, 2021
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-do of #5938