Skip to content

Expose vtctld gRPC port in local Docker example + update VTAdmin README#7306

Merged
rohit-nayak-ps merged 1 commit intovitessio:masterfrom
tinyspeck:sarabee-vtadmin-docker-vtctlds-and-you
Jan 15, 2021
Merged

Expose vtctld gRPC port in local Docker example + update VTAdmin README#7306
rohit-nayak-ps merged 1 commit intovitessio:masterfrom
tinyspeck:sarabee-vtadmin-docker-vtctlds-and-you

Conversation

@doeg
Copy link
Contributor

@doeg doeg commented Jan 15, 2021

Signed-off-by: Sara Bee 855595+doeg@users.noreply.github.com

Description

A couple tiny changes to get ✨ #7266 ✨ working with local Docker! (I promise promise to add a tidy make target in lieu of those four five README steps... soon... 🙈)

Screen Shot 2021-01-15 at 4 00 44 PM

Related Issue(s)

Checklist

  • Should this PR be backported? N/A
  • Tests were added or are not required N/A
  • Documentation was added or is not required

Deployment Notes

N/A

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build
  • VTAdmin

Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
Copy link
Contributor

@ajm188 ajm188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg2m

cd web/vtadmin
npm install
REACT_APP_VTADMIN_API_ADDRESS="http://127.0.0.1:15999" npm start
REACT_APP_VTADMIN_API_ADDRESS="http://127.0.0.1:14200" npm start
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:chef-kiss:

@rohit-nayak-ps rohit-nayak-ps merged commit 0fa0fc7 into vitessio:master Jan 15, 2021
@askdba askdba added this to the v9.0 milestone Jan 19, 2021
@doeg doeg deleted the sarabee-vtadmin-docker-vtctlds-and-you branch November 1, 2021 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants