[vtadmin-api] Reorganize tablet-related functions into vtadmin/cluster/cluster.go#7553
Merged
rohit-nayak-ps merged 8 commits intovitessio:masterfrom Feb 26, 2021
Merged
Conversation
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
ajm188
reviewed
Feb 25, 2021
Contributor
ajm188
left a comment
ajm188
left a comment
There was a problem hiding this comment.
I like this separation a lot better; thank you for doing it!! I have a couple small comments but looks great
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
Contributor
Author
|
@ajm188 this is ready for another pass, when you get a sec. |
ajm188
approved these changes
Feb 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Here's the refactoring I promised to do for #7528 (comment).
Changes:
tablets.gointocluster.goso functions have a signature offunc (c *Cluster) ...getTablets,findTablet, andfindNTabletsout ofapi.goand intocluster.go+ adds testserrors.goout ofpackage vtadminand intopackage errorsso that it can be shared byapi.go+cluster.goI staged this internally + it works as expected.
Related Issue(s)
Checklist
Deployment Notes
N/A
Impacted Areas in Vitess
Components that this PR will affect: