Corrects the comment handling in vitess#7581
Merged
harshit-gangal merged 1 commit intovitessio:masterfrom Mar 2, 2021
Merged
Conversation
Signed-off-by: GuptaManan100 <manan@planetscale.com>
harshit-gangal
approved these changes
Mar 2, 2021
Comment on lines
-67
to
-75
| // NewTokenizer creates a new Tokenizer reading a sql | ||
| // string from the io.Reader. | ||
| func NewTokenizer(r io.Reader) *Tokenizer { | ||
| return &Tokenizer{ | ||
| InStream: r, | ||
| buf: make([]byte, defaultBufSize), | ||
| } | ||
| } | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Vitess treats everything after
--as a comment just like MySQL. This means that the querySET @S = 1--4is valid on both MySQL and Vitess. Refer to https://dev.mysql.com/doc/refman/8.0/en/ansi-diff-comments.html for MySQL documentation regarding the sameRelated Issue(s)
Checklist
Impacted Areas in Vitess
Components that this PR will affect: