Adds Planning and Parsing Support for Truncate, Rename, Drop Index and Flush#7242
Merged
systay merged 16 commits intovitessio:masterfrom Jan 11, 2021
Merged
Adds Planning and Parsing Support for Truncate, Rename, Drop Index and Flush#7242systay merged 16 commits intovitessio:masterfrom
systay merged 16 commits intovitessio:masterfrom
Conversation
Signed-off-by: GuptaManan100 <manan@planetscale.com>
…lush Signed-off-by: GuptaManan100 <manan@planetscale.com>
Signed-off-by: GuptaManan100 <manan@planetscale.com>
Signed-off-by: GuptaManan100 <manan@planetscale.com>
Signed-off-by: GuptaManan100 <manan@planetscale.com>
GuptaManan100
force-pushed
the
rename-truncate-flush
branch
from
8292b18 to
a1d387d
Compare
Signed-off-by: GuptaManan100 <manan@planetscale.com>
Signed-off-by: GuptaManan100 <manan@planetscale.com>
GuptaManan100
changed the title
GuptaManan100
requested review from
harshit-gangal,
shlomi-noach and
systay
as code owners
Signed-off-by: GuptaManan100 <manan@planetscale.com>
Contributor
|
@GuptaManan100 please make sure to merge |
Signed-off-by: GuptaManan100 <manan@planetscale.com>
…lush Signed-off-by: GuptaManan100 <manan@planetscale.com>
Contributor
Author
|
Ah yes, this was also the reason why my PR was failing all the tests even though they were passing locally. Thankyou @shlomi-noach! |
Signed-off-by: GuptaManan100 <manan@planetscale.com>
Signed-off-by: GuptaManan100 <manan@planetscale.com>
Signed-off-by: GuptaManan100 <manan@planetscale.com>
Signed-off-by: GuptaManan100 <manan@planetscale.com>
Signed-off-by: GuptaManan100 <manan@planetscale.com>
Signed-off-by: GuptaManan100 <manan@planetscale.com>
systay
reviewed
Jan 8, 2021
systay
reviewed
Jan 8, 2021
systay
approved these changes
Jan 8, 2021
Collaborator
systay
left a comment
systay
left a comment
There was a problem hiding this comment.
Except for the comment about formatTwoOptionsNicely, LGTM
Contributor
WHOA! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Planning and Parsing Support for Truncate, Drop Index, Rename and Flush. Also, create Index is now converted to an alter table statement during parsing. DDL struct has now been removed since all the different types now have their own structs.