[vtadmin-web] Add common max-width to infrastructure table views#7760
Merged
ajm188 merged 1 commit intovitessio:masterfrom Mar 29, 2021
Merged
[vtadmin-web] Add common max-width to infrastructure table views#7760ajm188 merged 1 commit intovitessio:masterfrom
ajm188 merged 1 commit intovitessio:masterfrom
Conversation
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
ajm188
approved these changes
Mar 29, 2021
Contributor
ajm188
left a comment
ajm188
left a comment
There was a problem hiding this comment.
lgtm! just waiting for the tests to rerun, and then I'll merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sara Bee 855595+doeg@users.noreply.github.com
Description
Continuing the theme of "tiny janitorial PRs pulled out of the demo branch", this one adds a common
max-widthclass so our infrastructure tables don't look so goofy on wide screens. (Mobile-friendly layout to come... someday... 😊)I realize this seems like a fair amount of repetition but I don't want to put the max-width in the top-level App component as that ends up being really inflexible when we do want the full width. (Like super long names on detail pages, for example.)
Related Issue(s)
N/A
Checklist
Deployment Notes
N/A
Impacted Areas in Vitess
Components that this PR will affect: