Skip to content

[vtadmin] Add support for additional service healthchecks in grpcserver#7635

Merged
rafael merged 1 commit intovitessio:masterfrom
tinyspeck:am_vtadmin_grpcserver_healthchecks
Mar 8, 2021
Merged

[vtadmin] Add support for additional service healthchecks in grpcserver#7635
rafael merged 1 commit intovitessio:masterfrom
tinyspeck:am_vtadmin_grpcserver_healthchecks

Conversation

@ajm188
Copy link
Contributor

@ajm188 ajm188 commented Mar 8, 2021

Description

What it says in the title.

Then, update vtadmin's API to default to registering itself as SERVING
under the "vtadmin.VTAdminServer" name.

Signed-off-by: Andrew Mason amason@slack-corp.com

Related Issue(s)

Checklist

  • Should this PR be backported? no
  • Tests were added or are not required not required
  • Documentation was added or is not required

Deployment Notes

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build/CI
  • VTAdmin

Then, update vtadmin's API to default to registering itself as SERVING
under the "vtadmin.VTAdminServer" name.

Signed-off-by: Andrew Mason <amason@slack-corp.com>
@ajm188 ajm188 requested review from doeg and rohit-nayak-ps March 8, 2021 01:56
@ajm188 ajm188 changed the title Add support for additional service healthchecks in grpcserver [vtadmin] Add support for additional service healthchecks in grpcserver Mar 8, 2021
Copy link
Member

@rafael rafael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rafael rafael merged commit a6bee38 into vitessio:master Mar 8, 2021
@askdba askdba added the Component: VTAdmin VTadmin interface label Mar 10, 2021
@askdba askdba added this to the v10.0 milestone Mar 10, 2021
@ajm188 ajm188 deleted the am_vtadmin_grpcserver_healthchecks branch May 29, 2021 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: VTAdmin VTadmin interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[vtadmin] Add support to vtadmin/grpcserver for additional service healthchecks

4 participants