[8.0] Disable reserved connections by default#6859
Merged
harshit-gangal merged 1 commit intovitessio:release-8.0from Oct 14, 2020
Merged
[8.0] Disable reserved connections by default#6859harshit-gangal merged 1 commit intovitessio:release-8.0from
harshit-gangal merged 1 commit intovitessio:release-8.0from
Conversation
harshit-gangal
approved these changes
Oct 12, 2020
Signed-off-by: Andres Taylor <andres@planetscale.com>
harshit-gangal
force-pushed
the
disable-reserved-connections
branch
from
c3dc2f4 to
916754e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are still not recommending users to enable reserved connections.
Only enable it while you do something that you know needs reserved connections, such as an installation or to do a report.
If you by accident execute a SET statement during the setup of a connection with Vitess, so that all your connections end up needing reserved connections, you loose the benefits of connection pooling and this will put a heavy burden on your tablets.