Skip to content

[vtadmin-web] Add TextInput component#7366

Merged
rohit-nayak-ps merged 1 commit intovitessio:masterfrom
tinyspeck:sarabee-vtadmin-input-experiments
Jan 25, 2021
Merged

[vtadmin-web] Add TextInput component#7366
rohit-nayak-ps merged 1 commit intovitessio:masterfrom
tinyspeck:sarabee-vtadmin-input-experiments

Conversation

@doeg
Copy link
Contributor

@doeg doeg commented Jan 25, 2021

Signed-off-by: Sara Bee 855595+doeg@users.noreply.github.com

Description

✨ Staged at http://vtadmin.puppy.software/debug

A first pass at a TextInput component. I'll probably still mess with it but...! It's something. Also normalized the button heights to match the text input.

Couple caveats:

  • Haven't tested this on Firefox or IE
  • Component documentation is... lacking. 😊

Screen Shot 2021-01-24 at 9 10 37 PM

Screen Shot 2021-01-24 at 9 10 32 PM

Related Issue(s)

N/A

Checklist

  • Should this PR be backported?
  • Tests were added or are not required N/A
  • Documentation was added or is not required N/A

Deployment Notes

N/A

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build
  • VTAdmin

@doeg doeg requested a review from ajm188 as a code owner January 25, 2021 02:14
@doeg doeg requested a review from rohit-nayak-ps January 25, 2021 02:14
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
@doeg doeg force-pushed the sarabee-vtadmin-input-experiments branch from 028ab7a to 38aff4d Compare January 25, 2021 03:24
Copy link
Member

@rohit-nayak-ps rohit-nayak-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rohit-nayak-ps rohit-nayak-ps merged commit 9810096 into vitessio:master Jan 25, 2021
@doeg doeg added the Component: VTAdmin VTadmin interface label Mar 16, 2021
@doeg doeg changed the title Add TextInput component [vtadmin-web] Add TextInput component Mar 16, 2021
@doeg doeg deleted the sarabee-vtadmin-input-experiments branch November 1, 2021 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: VTAdmin VTadmin interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants