Table GC: disable binary logging on best effort basis#7588
Merged
shlomi-noach merged 5 commits intovitessio:masterfrom Mar 9, 2021
Merged
Table GC: disable binary logging on best effort basis#7588shlomi-noach merged 5 commits intovitessio:masterfrom
shlomi-noach merged 5 commits intovitessio:masterfrom
Conversation
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Jacques Grove <aquarapid@gmail.com>
deepthi
reviewed
Mar 5, 2021
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
deepthi
approved these changes
Mar 8, 2021
Collaborator
deepthi
left a comment
There was a problem hiding this comment.
Please fix the typo and then merge.
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Contributor
|
Sorry for getting in here late; but I did modify the transition state times locally ; and performed a manual end-to-end verification. All good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
By way of optimization, our table lifecycle mechanism only purges rows on the primary tablet. It does so by disabling binary logging. Here's the explanation that is in the code:
With this PR, we disable binary logging on best-effort basis. Here's the explanation that is in the PR's code:
And so, running on e.g. Amazon Aurora, the lifecycle mechanism will not disable binary logging (it will try, but fail to, and silently proceed), and purge rows with binlogs enabled. Performance loss, but logic is sound.
Related Issue(s)
Checklist
Impacted Areas in Vitess
Components that this PR will affect: