CI: check run analysis to post JSON from file#7386
Merged
deepthi merged 2 commits intovitessio:masterfrom Jan 26, 2021
Merged
Conversation
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Collaborator
|
This looks fine to me. How about also changing the PR template to include CI? |
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Contributor
Author
Added |
deepthi
approved these changes
Jan 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The check runs analysis CI job sends the contents of the analysis, encoded as
base64, with acurlcommand. Currently as an argument, but that content grew to be too long.With this PR, we write the content to file, and ask
curlto attach it. With this approach the size limitation is lifted.Related Issue(s)
#7382
Checklist
Impacted Areas in Vitess
Components that this PR will affect:
CI
cc @deepthi