Replace the database name in result fields only if needed#7714
Merged
harshit-gangal merged 2 commits intovitessio:masterfrom Mar 22, 2021
Merged
Replace the database name in result fields only if needed#7714harshit-gangal merged 2 commits intovitessio:masterfrom
harshit-gangal merged 2 commits intovitessio:masterfrom
Conversation
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Collaborator
|
any tests that show the new behaviour? |
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
shlomi-noach
approved these changes
Mar 22, 2021
Member
Author
|
The earlier changes was about logical fix regarding database name in fields metadata. But, it was not doing the correct thing. So changed to fix it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We replace the database name with keyspace name for all the cases expect show queries.
The current change is to replace only if keyspace name is different than database name and also only for select queries when the fields database name is set to underlying database name.
Checklist
Deployment Notes
Impacted Areas in Vitess
Components that this PR will affect: