restore: check disable_active_reparents properly before waiting for position update#7703
Merged
deepthi merged 5 commits intovitessio:masterfrom Mar 30, 2021
Merged
restore: check disable_active_reparents properly before waiting for position update#7703deepthi merged 5 commits intovitessio:masterfrom
deepthi merged 5 commits intovitessio:masterfrom
Conversation
…osition update Signed-off-by: deepthi <deepthi@planetscale.com>
8 tasks
Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
sougou
approved these changes
Mar 30, 2021
This was referenced May 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In #7576 we intended to introduce a check in
startReplicationto skip waiting ifdisable_active_reparentsis set. The check was incorrect, this PR fixes it.#7576 breaks the case fixed in #5000, so I have added the necessary tests to ensure this doesn't break again.
Also, call
orc.EndMaintenanceonly if the backup/restore process is successful.Related Issue(s)
#7657
#4426
Checklist
Impacted Areas in Vitess
Components that this PR will affect: