Disallow foreign key constraint on ddl#7780
Merged
harshit-gangal merged 5 commits intovitessio:masterfrom Apr 4, 2021
Merged
Conversation
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
deepthi
reviewed
Apr 1, 2021
GuptaManan100
approved these changes
Apr 2, 2021
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
shlomi-noach
reviewed
Apr 4, 2021
Contributor
shlomi-noach
left a comment
shlomi-noach
left a comment
There was a problem hiding this comment.
Suggesting a few changes, otherwise this looks good!
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Vitess today allowed foreign keys constraint to be sent down to the mysql to be applied on the table.
In a sharded keyspace, they might not be correctly set and would fail user queries.
This change is to provide a
-foreign_keyflag on VTGate with default "allow" but with an option to change it to "disallow"Checklist
Impacted Areas in Vitess
Components that this PR will affect: