docker/vttestserver: Add MYSQL_BIND_HOST env#7293
Merged
deepthi merged 1 commit intovitessio:masterfrom Jan 14, 2021
Merged
Conversation
deepthi
reviewed
Jan 14, 2021
Collaborator
deepthi
left a comment
There was a problem hiding this comment.
LGTM but DCO needs to be fixed before we can merge.
Signed-off-by: Mike Cronce <mc@planetscale.com>
5a8c1f4 to
96e9fb3
Compare
Author
|
@deepthi should be all set, thanks! |
deepthi
approved these changes
Jan 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds an optional
MYSQL_BIND_HOSTenvironment variable to thevttestservercontainer; if included, this is passed as-mysql_bind_hosttovttestserverRelated Issue(s)
Checklist
Deployment Notes
Run as follows:
Impacted Areas in Vitess
Components that this PR will affect: