Addition of waitSig pprof argument to start recording on USR1#7616
Merged
deepthi merged 1 commit intovitessio:masterfrom Mar 5, 2021
Merged
Addition of waitSig pprof argument to start recording on USR1#7616deepthi merged 1 commit intovitessio:masterfrom
deepthi merged 1 commit intovitessio:masterfrom
Conversation
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
deepthi
approved these changes
Mar 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After running long benchmarks while profiling Vitess, the profiles start to get too big for
go tool pprofand return an EOF error. To counterattack this issue, we decided to stop recording at any given time by using #7594, and without affecting the benchmarks.However, we also want to control when to start recording. In the case of the benchmarks, we often have long preparation times where we insert and "warm-up" the system before practicing the actual benchmark. This is what this pull request brings: start recording at any given moment based on a received signal (USR1).
cc @vmg
Related Issue(s)
Checklist
Impacted Areas in Vitess
Components that this PR will affect: