Skip to content

Adds another case to merge routes for information_schema queries#7504

Merged
harshit-gangal merged 4 commits intovitessio:masterfrom
GuptaManan100:merge-information-schema
Feb 21, 2021
Merged

Adds another case to merge routes for information_schema queries#7504
harshit-gangal merged 4 commits intovitessio:masterfrom
GuptaManan100:merge-information-schema

Conversation

@GuptaManan100
Copy link
Copy Markdown
Contributor

@GuptaManan100 GuptaManan100 commented Feb 17, 2021

Fixes #7376

Signed-off-by: GuptaManan100 <manan@planetscale.com>
…e-information-schema

Signed-off-by:  <akilan.selvacoumar@planetscale.com>
@harshit-gangal
Copy link
Copy Markdown
Member

ast does not have to do with what the table qualifier is, we can move the ContainsOnlySystemSchema() logic from ast to logical plan and they can provide the same information needed for planner.

cc: @systay

Signed-off-by: Akilan Selvacoumar <akilan.selvacoumar@planetscale.com>

Signed-off-by:  <akilan.selvacoumar@planetscale.com>
@Akilan1999 Akilan1999 force-pushed the merge-information-schema branch from 9aa4d32 to 4cd2a7a Compare February 18, 2021 07:32
Copy link
Copy Markdown
Member

@harshit-gangal harshit-gangal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One nit comment

Signed-off-by: GuptaManan100 <manan@planetscale.com>
@harshit-gangal harshit-gangal merged commit 02376a3 into vitessio:master Feb 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to query information_schema.referential_constraints for DELETE_RULE column without qualifying column name

3 participants