Constraint names and database names with spaces.#7745
Merged
harshit-gangal merged 2 commits intovitessio:masterfrom Mar 26, 2021
Merged
Constraint names and database names with spaces.#7745harshit-gangal merged 2 commits intovitessio:masterfrom
harshit-gangal merged 2 commits intovitessio:masterfrom
Conversation
…and constraints Signed-off-by: GuptaManan100 <manan@planetscale.com>
Signed-off-by: GuptaManan100 <manan@planetscale.com>
harshit-gangal
approved these changes
Mar 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Running a query like
got rewritten to
by the parser. This issue arises because the name field was stored as a string rather than a ColIdent. Similar issues were also there in the database name fields. This PR addresses this issue.
After the changes, there is 1 extra shift-reduce conflict that has arisen. It has been verified that MySQL also has the shift reduce conflict and Vitess's behaviour emulates what MySQL does.
Related Issue(s)
Checklist
Impacted Areas in Vitess
Components that this PR will affect: