Skip to content

[vtadmin-web] Add icons + focus state to NavRail#7365

Merged
rohit-nayak-ps merged 1 commit intovitessio:masterfrom
tinyspeck:sarabee-vtadmin-navrail-icons
Jan 25, 2021
Merged

[vtadmin-web] Add icons + focus state to NavRail#7365
rohit-nayak-ps merged 1 commit intovitessio:masterfrom
tinyspeck:sarabee-vtadmin-navrail-icons

Conversation

@doeg
Copy link
Contributor

@doeg doeg commented Jan 25, 2021

Signed-off-by: Sara Bee 855595+doeg@users.noreply.github.com

Description

As it says on the tin!

Before:

Screen Shot 2021-01-24 at 7 28 11 PM

After:

Screen Shot 2021-01-24 at 8 42 22 PM

Screen Shot 2021-01-24 at 8 42 27 PM

Related Issue(s)

N/A

Checklist

  • Should this PR be backported?
  • Tests were added or are not required N/A
  • Documentation was added or is not required N/A

Deployment Notes

N/A

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build
  • VTAdmin

@doeg doeg requested review from ajm188 and rohit-nayak-ps January 25, 2021 01:40
@doeg
Copy link
Contributor Author

doeg commented Jan 25, 2021

Whoops, one sec -- of course I got one of the icons wrong. 😑

Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
@doeg
Copy link
Contributor Author

doeg commented Jan 25, 2021

Ok fixed! 😰 Sorry about that. This is ready for real now!

@doeg doeg force-pushed the sarabee-vtadmin-navrail-icons branch from 89fd9d6 to 1790bfb Compare January 25, 2021 01:50
Copy link
Member

@rohit-nayak-ps rohit-nayak-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rohit-nayak-ps rohit-nayak-ps merged commit 627f092 into vitessio:master Jan 25, 2021
@doeg doeg changed the title Add icons + focus state to NavRail [vtadmin-web] Add icons + focus state to NavRail Mar 16, 2021
@doeg doeg added the Component: VTAdmin VTadmin interface label Mar 16, 2021
@doeg doeg deleted the sarabee-vtadmin-navrail-icons branch November 1, 2021 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: VTAdmin VTadmin interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants