ci-workflow-gen: turn string to array to reduce conflicts#7582
Merged
shlomi-noach merged 3 commits intovitessio:masterfrom Mar 7, 2021
Merged
ci-workflow-gen: turn string to array to reduce conflicts#7582shlomi-noach merged 3 commits intovitessio:masterfrom
shlomi-noach merged 3 commits intovitessio:masterfrom
Conversation
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
rohit-nayak-ps
approved these changes
Mar 7, 2021
Member
rohit-nayak-ps
left a comment
rohit-nayak-ps
left a comment
There was a problem hiding this comment.
You beat me to this :-)
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In
ci-workflow-gen.go, the variableclusterListis becoming a problem:endtoendtests.In this PR we turn the string into an array of strings. Each "test shard" is listed on its own line, and this should almost eliminate conflicts.
Checklist
Deployment Notes
Impacted Areas in Vitess
Components that this PR will affect: