[vtctld] Add GetSrvVSchema command#7334
Merged
rohit-nayak-ps merged 3 commits intovitessio:masterfrom Jan 21, 2021
Merged
Conversation
added 2 commits
January 19, 2021 22:08
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
00c08d0 to
4f9ae68
Compare
doeg
approved these changes
Jan 21, 2021
| assert.Error(t, err) | ||
| } | ||
|
|
||
| func TestGetSrvVSchema(t *testing.T) { |
Contributor
There was a problem hiding this comment.
So amazing to have tests 😭 and the tests are good
ajm188
pushed a commit
to tinyspeck/vitess
that referenced
this pull request
Feb 11, 2021
[vtctld] Add GetSrvVSchema command
setassociative
pushed a commit
to tinyspeck/vitess
that referenced
this pull request
Mar 11, 2021
[vtctld] Add GetSrvVSchema command
ajm188
pushed a commit
to tinyspeck/vitess
that referenced
this pull request
Apr 6, 2021
[vtctld] Add GetSrvVSchema command Signed-off-by: Andrew Mason <amason@slack-corp.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
This implements
GetSrvVSchemain the vtctld service. Pretty straightforward.Sample output from local example:
Related Issue(s)
Checklist
Deployment Notes
Impacted Areas in Vitess
Components that this PR will affect: