Online DDL: internal support for eta_seconds#7630
Merged
shlomi-noach merged 1 commit intovitessio:masterfrom Mar 8, 2021
Merged
Online DDL: internal support for eta_seconds#7630shlomi-noach merged 1 commit intovitessio:masterfrom
shlomi-noach merged 1 commit intovitessio:masterfrom
Conversation
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Contributor
Author
|
This is now ready for review. This PR only implements internal support for Future PRs will:
|
Contributor
Author
|
cc @piki |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Objective: make both migration progress and ETA accessible to the user.
Initial commits:
This PR adds the column
eta_secondsto_vt.schema_migrationsand provides the following initial support:eta=?query param on/schema-migration/report-status(which is called ongh-ostandpt-oscmigrations)GH_OST_ETA_SECONDSingh-oststatus hookTODO/related:
VExecRelated Issue(s)
gh-ostbuild: hooks: reporting GH_OST_ETA_SECONDS. ETA as part of migration context openark/gh-ost#17Checklist
Deployment Notes
Impacted Areas in Vitess
Components that this PR will affect: