Skip to content

[concurrency] Add guard against potentially blocking forever in ErrorGroup.Wait() when NumGoroutines is 0#7463

Merged
deepthi merged 1 commit intovitessio:masterfrom
tinyspeck:am_error_group_zero
Feb 8, 2021
Merged

[concurrency] Add guard against potentially blocking forever in ErrorGroup.Wait() when NumGoroutines is 0#7463
deepthi merged 1 commit intovitessio:masterfrom
tinyspeck:am_error_group_zero

Conversation

@ajm188
Copy link
Contributor

@ajm188 ajm188 commented Feb 7, 2021

Closes #7462

Signed-off-by: Andrew Mason amason@slack-corp.com

Description

Related Issue(s)

Checklist

  • Should this PR be backported? No (error group is in master but not any release branches)
  • Tests were added or are not required
  • Documentation was added or is not required N/A

Deployment Notes

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build/CI
  • VTAdmin

Closes vitessio#7462

Signed-off-by: Andrew Mason <amason@slack-corp.com>
@ajm188 ajm188 requested a review from deepthi February 7, 2021 17:10
@ajm188 ajm188 requested a review from sougou as a code owner February 7, 2021 17:10
@ajm188 ajm188 changed the title Add guard against potentially blocking forever when NumGoroutines is 0 [concurrency] Add guard against potentially blocking forever in ErrorGroup.Wait() when NumGoroutines is 0 Feb 7, 2021
@deepthi deepthi merged commit 39df6cd into vitessio:master Feb 8, 2021
@askdba askdba added this to the v10.0 milestone Feb 8, 2021
@ajm188 ajm188 deleted the am_error_group_zero branch March 4, 2021 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[concurrency] ErrorGroup blocks forever when Wait is called with NumGoroutines = 0

3 participants