Skip to content

[vtadmin-web] Add comments + 'options' parameter to API hooks#7754

Merged
rohit-nayak-ps merged 1 commit intovitessio:masterfrom
tinyspeck:sarabee-vtadmin-web-hooks-nits
Mar 28, 2021
Merged

[vtadmin-web] Add comments + 'options' parameter to API hooks#7754
rohit-nayak-ps merged 1 commit intovitessio:masterfrom
tinyspeck:sarabee-vtadmin-web-hooks-nits

Conversation

@doeg
Copy link
Copy Markdown
Contributor

@doeg doeg commented Mar 27, 2021

Signed-off-by: Sara Bee 855595+doeg@users.noreply.github.com

Description

A tiny bit of janitorial work pulled out of the demo branch.

This updates vtadmin-web's API hooks to:

  • Add a passthrough for react-query options, which are not used yet (I know, I know) but establish a pattern that will be used in the future, starting with workflows.
  • Clean up types
  • Add a bit of commentary

Related Issue(s)

N/A

Checklist

  • Should this PR be backported? No
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

N/A

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build/CI
  • VTAdmin

Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
@doeg doeg requested review from ajm188 and rohit-nayak-ps March 27, 2021 17:21
Copy link
Copy Markdown
Contributor

@ajm188 ajm188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg2m!

@rohit-nayak-ps rohit-nayak-ps merged commit 13e7372 into vitessio:master Mar 28, 2021
@askdba askdba added the Component: VTAdmin VTadmin interface label Apr 1, 2021
@askdba askdba added this to the v10.0 milestone Apr 1, 2021
@doeg doeg deleted the sarabee-vtadmin-web-hooks-nits branch November 1, 2021 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: VTAdmin VTadmin interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants