Skip to content

Allows any ordering of generic options in column definitions#7459

Merged
systay merged 7 commits intovitessio:masterfrom
planetscale:alter-table-not-null
Feb 10, 2021
Merged

Allows any ordering of generic options in column definitions#7459
systay merged 7 commits intovitessio:masterfrom
planetscale:alter-table-not-null

Conversation

@GuptaManan100
Copy link
Contributor

Allows any ordering of generic options in column definitions

FIxes #7378 #7455

Signed-off-by: GuptaManan100 <manan@planetscale.com>
Signed-off-by: GuptaManan100 <manan@planetscale.com>
Copy link
Contributor

@shlomi-noach shlomi-noach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

M T G L

Signed-off-by: GuptaManan100 <manan@planetscale.com>
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@GuptaManan100 GuptaManan100 requested a review from sougou as a code owner February 9, 2021 05:45
@harshit-gangal
Copy link
Member

needs conflict resolution.

Signed-off-by: Andres Taylor <andres@planetscale.com>
Copy link
Contributor

@sougou sougou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eyeballed. Looks good.

Signed-off-by: GuptaManan100 <manan@planetscale.com>
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@systay systay merged commit 43cb3fb into vitessio:master Feb 10, 2021
@systay systay deleted the alter-table-not-null branch February 10, 2021 05:01
@askdba askdba added this to the v10.0 milestone Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parsing error/warning caused by AUTO_INCREMENT after PRIMARY KEY on a column

6 participants