Skip to content

[vtadmin-web] Add React Router + a skeleton /debug page to VTAdmin#7310

Merged
rohit-nayak-ps merged 1 commit intovitessio:masterfrom
tinyspeck:sarabee-vtadmin-debug-page
Jan 18, 2021
Merged

[vtadmin-web] Add React Router + a skeleton /debug page to VTAdmin#7310
rohit-nayak-ps merged 1 commit intovitessio:masterfrom
tinyspeck:sarabee-vtadmin-debug-page

Conversation

@doeg
Copy link
Copy Markdown
Contributor

@doeg doeg commented Jan 16, 2021

Signed-off-by: Sara Bee 855595+doeg@users.noreply.github.com

Description

Adds react router + a /debug page. Another tiny PR pulled out of a bigger branch.

For a little context, I plan to co-opt the debug page as an informal style guide as I add all of the components in the Figma spec. (In the past, I've used Storybook for this, but I think that's way overkill for what we need for the near future.)

No one asked, but my $0.02 anyway (haha). I personally prefer ui-router over React Router. (I think it's more straightforward.) That said, the ui-router documentation is very painful to navigate. React Router has better documentation and I think it's fair to that it's still the industry (or at least React!) standard, so I think it's a better + more approachable choice for an open source project.

Looks great so far, right? :D (Just kidding.)

Screen Shot 2021-01-16 at 1 40 55 PM

Related Issue(s)

N/A

Checklist

  • Should this PR be backported?
  • Tests were added or are not required N/A
  • Documentation was added or is not required N/A

Deployment Notes

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build
  • VTAdmin

Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
@doeg doeg requested a review from ajm188 as a code owner January 16, 2021 18:42
Copy link
Copy Markdown
Contributor

@ajm188 ajm188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@rohit-nayak-ps rohit-nayak-ps merged commit a0aa954 into vitessio:master Jan 18, 2021
@askdba askdba added this to the v9.0 milestone Jan 19, 2021
@doeg doeg changed the title Add React Router + a skeleton /debug page to VTAdmin [vtadmin-web] Add React Router + a skeleton /debug page to VTAdmin Mar 16, 2021
@doeg doeg added the Component: VTAdmin VTadmin interface label Mar 16, 2021
@doeg doeg deleted the sarabee-vtadmin-debug-page branch November 1, 2021 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: VTAdmin VTadmin interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants