[vtadmin-web] Add React Router + a skeleton /debug page to VTAdmin#7310
Merged
rohit-nayak-ps merged 1 commit intovitessio:masterfrom Jan 18, 2021
Merged
Conversation
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sara Bee 855595+doeg@users.noreply.github.com
Description
Adds react router + a /debug page. Another tiny PR pulled out of a bigger branch.
For a little context, I plan to co-opt the debug page as an informal style guide as I add all of the components in the Figma spec. (In the past, I've used Storybook for this, but I think that's way overkill for what we need for the near future.)
No one asked, but my $0.02 anyway (haha). I personally prefer ui-router over React Router. (I think it's more straightforward.) That said, the ui-router documentation is very painful to navigate. React Router has better documentation and I think it's fair to that it's still the industry (or at least React!) standard, so I think it's a better + more approachable choice for an open source project.
Looks great so far, right? :D (Just kidding.)
Related Issue(s)
N/A
Checklist
Deployment Notes
Impacted Areas in Vitess
Components that this PR will affect: