Skip to content

[vtctld] Migrate GetVSchema to VtctldServer#7360

Merged
rohit-nayak-ps merged 3 commits intovitessio:masterfrom
tinyspeck:am_vtctld_getvschema
Jan 24, 2021
Merged

[vtctld] Migrate GetVSchema to VtctldServer#7360
rohit-nayak-ps merged 3 commits intovitessio:masterfrom
tinyspeck:am_vtctld_getvschema

Conversation

@ajm188
Copy link
Contributor

@ajm188 ajm188 commented Jan 23, 2021

Description

This PR addsGetVSchema to the VtctldServer API.

Example:

❯ vtctldclient --server "localhost:15999" GetVSchema commerce
{
  "sharded": false,
  "vindexes": {
  },
  "tables": {
    "corder": {
      "type": "",
      "column_vindexes": [
      ],
      "auto_increment": null,
      "columns": [
      ],
      "pinned": "",
      "column_list_authoritative": false
    },
    "customer": {
      "type": "",
      "column_vindexes": [
      ],
      "auto_increment": null,
      "columns": [
      ],
      "pinned": "",
      "column_list_authoritative": false
    },
    "product": {
      "type": "",
      "column_vindexes": [
      ],
      "auto_increment": null,
      "columns": [
      ],
      "pinned": "",
      "column_list_authoritative": false
    }
  },
  "require_explicit_routing": false
}

Related Issue(s)

Checklist

  • Should this PR be backported? No
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build
  • VTAdmin

Andrew Mason added 3 commits January 23, 2021 18:30
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
@ajm188 ajm188 requested review from doeg and rohit-nayak-ps January 23, 2021 23:38
@ajm188 ajm188 requested a review from sougou as a code owner January 23, 2021 23:38
Copy link
Member

@rohit-nayak-ps rohit-nayak-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rohit-nayak-ps rohit-nayak-ps merged commit bc44b1f into vitessio:master Jan 24, 2021
@askdba askdba added this to the v9.0 milestone Jan 25, 2021
ajm188 pushed a commit to tinyspeck/vitess that referenced this pull request Feb 11, 2021
[vtctld] Migrate GetVSchema to VtctldServer
@ajm188 ajm188 deleted the am_vtctld_getvschema branch March 4, 2021 21:32
setassociative pushed a commit to tinyspeck/vitess that referenced this pull request Mar 11, 2021
[vtctld] Migrate GetVSchema to VtctldServer
ajm188 pushed a commit to tinyspeck/vitess that referenced this pull request Apr 6, 2021
[vtctld] Migrate GetVSchema to VtctldServer

Signed-off-by: Andrew Mason <amason@slack-corp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants