Fix information_schema query with system schema in table_schema filter#7430
Merged
harshit-gangal merged 6 commits intovitessio:masterfrom Feb 3, 2021
Merged
Fix information_schema query with system schema in table_schema filter#7430harshit-gangal merged 6 commits intovitessio:masterfrom
harshit-gangal merged 6 commits intovitessio:masterfrom
Conversation
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
…ault route if it is a system schema Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
… from bv if tablet will replace it Signed-off-by: Harshit Gangal <harshit@planetscale.com>
systay
approved these changes
Feb 3, 2021
Collaborator
systay
left a comment
systay
left a comment
There was a problem hiding this comment.
Looks good. I'm just missing an end to end test that tests the query we set out to fix in the first place:
mysql> SELECT COUNT(*) FROM INFORMATION_SCHEMA.TABLES WHERE table_schema = 'performance_schema' AND table_name = 'foo';Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Member
Author
addressed. |
systay
pushed a commit
to planetscale/vitess
that referenced
this pull request
May 11, 2021
Backport of vitessio#7430 This is a combination of 6 commits. * added system schema in where clause plan test * added executor unit test * added logic to check table_schema of where clause and redirect to default route if it is a system schema * added e2e test * set the bindvars for the normalized predicates and remove schema name from bv if tablet will replace it * added e2e test having table_schema and table_name in where clause Signed-off-by: Harshit Gangal <harshit@planetscale.com> Signed-off-by: Andres Taylor <andres@planetscale.com>
rafael
pushed a commit
to tinyspeck/vitess
that referenced
this pull request
May 11, 2021
Backport of vitessio#7430 This is a combination of 6 commits. * added system schema in where clause plan test * added executor unit test * added logic to check table_schema of where clause and redirect to default route if it is a system schema * added e2e test * set the bindvars for the normalized predicates and remove schema name from bv if tablet will replace it * added e2e test having table_schema and table_name in where clause Signed-off-by: Harshit Gangal <harshit@planetscale.com> Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
Checklist
Deployment Notes
Impacted Areas in Vitess
Components that this PR will affect: