[vtctld] Migrate GetSrvKeyspace as GetSrvKeyspaces in VtctldServer#7680
Merged
deepthi merged 5 commits intovitessio:masterfrom Mar 15, 2021
Merged
[vtctld] Migrate GetSrvKeyspace as GetSrvKeyspaces in VtctldServer#7680deepthi merged 5 commits intovitessio:masterfrom
deepthi merged 5 commits intovitessio:masterfrom
Conversation
added 4 commits
March 14, 2021 11:35
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
…Schema there Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Contributor
Author
|
Latest commit reimplementing the legacy command using the new implementation: BeforeAfter |
doeg
approved these changes
Mar 14, 2021
Contributor
doeg
left a comment
There was a problem hiding this comment.
Love to reimplement a legacy command using a new implementation. Still looks good to me!
@deepthi @rohit-nayak-ps would you mind looking at this one too, when you get a chance? :D
deepthi
approved these changes
Mar 15, 2021
Collaborator
deepthi
left a comment
There was a problem hiding this comment.
Nice work! You always do such a nice job with comments and unit tests 💯
rafael
pushed a commit
to tinyspeck/vitess
that referenced
this pull request
Apr 6, 2021
[vtctld] Migrate GetSrvKeyspace as GetSrvKeyspaces in VtctldServer Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR migrates the
GetSrvKeyspacecommand and rpc to the newerVtctldServer, renamed asGetSrvKeyspaces. Changes:Related Issue(s)
Checklist
Deployment Notes
Example usage:
Impacted Areas in Vitess
Components that this PR will affect: