[vtctld] Migrate ListBackups as GetBackups in new vtctld server#7352
Merged
rohit-nayak-ps merged 5 commits intovitessio:masterfrom Jan 23, 2021
Merged
[vtctld] Migrate ListBackups as GetBackups in new vtctld server#7352rohit-nayak-ps merged 5 commits intovitessio:masterfrom
rohit-nayak-ps merged 5 commits intovitessio:masterfrom
Conversation
added 5 commits
January 22, 2021 17:04
Signed-off-by: Andrew Mason <amason@slack-corp.com>
…oproto Signed-off-by: Andrew Mason <amason@slack-corp.com>
…d tests Signed-off-by: Andrew Mason <amason@slack-corp.com>
The reason this should not be exported is that we want to enforce a singleton usage for these testutil implementations, and the best way to ensure that is to make it impossible for users to create a new instance by hiding the type away. Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
doeg
approved these changes
Jan 23, 2021
Contributor
doeg
left a comment
doeg
left a comment
There was a problem hiding this comment.
Looks good to me. I trust your judgement on whether you want to try testing this locally before it's merged!
| } | ||
|
|
||
| // ListBackups is part of the backupstorage.BackupStorage interface. | ||
| func (bs *backupStorage) ListBackups(ctx context.Context, dir string) ([]backupstorage.BackupHandle, error) { |
Contributor
There was a problem hiding this comment.
Implementing a whole new fake is so much work but it will definitely pay off 🏆 thank you!
ajm188
pushed a commit
to tinyspeck/vitess
that referenced
this pull request
Feb 11, 2021
[vtctld] Migrate ListBackups as GetBackups in new vtctld server
setassociative
pushed a commit
to tinyspeck/vitess
that referenced
this pull request
Mar 11, 2021
[vtctld] Migrate ListBackups as GetBackups in new vtctld server
ajm188
pushed a commit
to tinyspeck/vitess
that referenced
this pull request
Apr 6, 2021
[vtctld] Migrate ListBackups as GetBackups in new vtctld server Signed-off-by: Andrew Mason <amason@slack-corp.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrates
ListBackupsasGetBackupsin the new rpcs. Functionality is the same. I also added a util package for going from abackupstorage.BackupHandleto a proto message, and I un-exported theTestTabletManagerClienttype I added in #7346 because I want to enforce the singleton pattern I documented through the type system.Example:
Related Issue(s)
Checklist
Deployment Notes
Impacted Areas in Vitess
Components that this PR will affect: