Add percona-toolkit (for pt-osc/pt-online-schema-change) to the docker/lite images#7603
Merged
deepthi merged 1 commit intovitessio:masterfrom Mar 5, 2021
Merged
Add percona-toolkit (for pt-osc/pt-online-schema-change) to the docker/lite images#7603deepthi merged 1 commit intovitessio:masterfrom
deepthi merged 1 commit intovitessio:masterfrom
Conversation
docker/lite container images Signed-off-by: Jacques Grove <aquarapid@gmail.com>
shlomi-noach
reviewed
Mar 4, 2021
Contributor
shlomi-noach
left a comment
shlomi-noach
left a comment
There was a problem hiding this comment.
I believe you need libdbi and libdbd-mysql as dependencies.
Contributor
|
@aquarapid what does this do to image size ? If its a large increase I think it would be better to just have a flavor that includes the files. |
Contributor
Author
Adding the percona-toolkit package pulls in the necessary deps, both on debian and UBI (redhat). |
Contributor
Author
@dkhenry About 3.5% increase in image (uncompressed); I expect it to be a bit less compressed, since the new files are mostly perl and compresses well. |
Contributor
|
Thats very acceptable. 🚢 |
deepthi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7602
Signed-off-by: Jacques Grove aquarapid@gmail.com