Skip to content

cache: handle all possible initialization cases#7556

Merged
deepthi merged 1 commit intovitessio:masterfrom
vmg:vmg/cache-init
Feb 26, 2021
Merged

cache: handle all possible initialization cases#7556
deepthi merged 1 commit intovitessio:masterfrom
vmg:vmg/cache-init

Conversation

@vmg
Copy link
Collaborator

@vmg vmg commented Feb 26, 2021

Description

It was just an over-eager check. Unit tests have been introduced

Related Issue(s)

Checklist

  • Should this PR be backported?
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build/CI
  • VTAdmin

Signed-off-by: Vicent Marti <vmg@strn.cat>
Copy link
Collaborator

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

panic from LFU cache when cache_size is set to 0

3 participants