[vitessdriver|vtadmin] Support Ping in vitessdriver, use in vtadmin to healthcheck connections during Dial#7709
Merged
deepthi merged 4 commits intovitessio:masterfrom Mar 18, 2021
Conversation
added 4 commits
March 17, 2021 09:57
Ref: https://golang.org/pkg/database/sql/driver/#Pinger Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
doeg
reviewed
Mar 17, 2021
| if vtgate.conn != nil { | ||
| span.Annotate("is_noop", true) | ||
|
|
||
| // (TODO:@amason): consider a quick Ping() check in this case, and get a |
Contributor
There was a problem hiding this comment.
A good suggestion, turns out!
Contributor
Author
|
Looks like the onlineddl_devert test is having trouble downloading a dependency from mongodb: |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a longstanding issue in vtadmin, where if vtadmin had
Dial-ed a cluster, obtained a connection to a vtgate, and that vtgate was torn down, that cluster would become unusable without restarting vtadmin, and we would see the following, forever:To fix this, I've introduced the following:
database/sq/driver.Pingerinterface invitessdriver, which just issues aselect 1query.PingduringVTGateProxy.Dialin the case where the proxy has a non-nil connection. We set a configurable timeout here, to avoid blocking forever, and if the call fails we attempt to close the connection and then fall through to the "discover new vtgate and dial it" phase of theDialmethod. If the ping check succeeds, we know we can just keep using that connection.Related Issue(s)
Checklist
Deployment Notes
Impacted Areas in Vitess
Components that this PR will affect: