[vtctldclient] Set SilenceErrors on the root command, so we don't double-log#7404
Merged
deepthi merged 1 commit intovitessio:masterfrom Feb 2, 2021
Merged
Conversation
Signed-off-by: Andrew Mason <amason@slack-corp.com>
doeg
approved these changes
Jan 28, 2021
ajm188
pushed a commit
to tinyspeck/vitess
that referenced
this pull request
Feb 11, 2021
…ce_errors [vtctldclient] Set `SilenceErrors` on the root command, so we don't double-log
setassociative
pushed a commit
to tinyspeck/vitess
that referenced
this pull request
Mar 11, 2021
…ce_errors [vtctldclient] Set `SilenceErrors` on the root command, so we don't double-log
rafael
pushed a commit
to tinyspeck/vitess
that referenced
this pull request
Apr 6, 2021
…ce_errors [vtctldclient] Set `SilenceErrors` on the root command, so we don't double-log
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What it says in the title. I noticed this while I was doing testing for #7395.
Before (
SilenceErrors: false):After (
SilenceErrors: true):Related Issue(s)
Checklist
Deployment Notes
Impacted Areas in Vitess
Components that this PR will affect: