[vtadmin-web] Add Button + Icon components#7350
Merged
rohit-nayak-ps merged 2 commits intovitessio:masterfrom Jan 23, 2021
Merged
[vtadmin-web] Add Button + Icon components#7350rohit-nayak-ps merged 2 commits intovitessio:masterfrom
rohit-nayak-ps merged 2 commits intovitessio:masterfrom
Conversation
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
doeg
commented
Jan 22, 2021
|
|
||
| // All icons are from the VTAdmin Figma icon library: | ||
| // https://www.figma.com/file/By3SoETBRHpOirv3Ctfxdq/Designs | ||
| export const Icon = ({ icon, ...props }: Props) => { |
Contributor
Author
There was a problem hiding this comment.
Between the SVGs and the Icons enum, it's a lot of boilerplate BUT I'm... happy with this implementation. Mostly? It's one of the best SVG/icon implementations I've worked with, but it's still pretty clunky. 😕 The trade-off here is verbosity for type-safety.
It's possible we could reduce almost all of this boilerplate through some cheeky codegen, but that's not particularly well-supported in TypeScript (compared to Go) so it'll take some exploration.
doeg
force-pushed
the
sarabee-vtadmin-components
branch
2 times, most recently
from
5216321 to
559c1c9
Compare
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
doeg
force-pushed
the
sarabee-vtadmin-components
branch
from
559c1c9 to
1d7481a
Compare
doeg
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sara Bee 855595+doeg@users.noreply.github.com
Description
✨ Staged at http://vtadmin.puppy.software/debug
Buttons! Icons! Dark mode (sorta)!
Related Issue(s)
N/A
Checklist
Deployment Notes
N/A
Impacted Areas in Vitess
Components that this PR will affect: