[vtadmin-web] Add routes and simple tables for all entities#7440
Merged
rohit-nayak-ps merged 1 commit intovitessio:masterfrom Feb 4, 2021
Merged
[vtadmin-web] Add routes and simple tables for all entities#7440rohit-nayak-ps merged 1 commit intovitessio:masterfrom
rohit-nayak-ps merged 1 commit intovitessio:masterfrom
Conversation
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
ajm188
approved these changes
Feb 3, 2021
Contributor
ajm188
left a comment
ajm188
left a comment
There was a problem hiding this comment.
I continue to love vtadmin.puppy.software 😍
| const res = await vtfetch(endpoint); | ||
| // vtfetchEntities is a helper function for querying vtadmin-api endpoints | ||
| // that return a list of protobuf entities. | ||
| export const vtfetchEntities = async <T>(opts: { |
| export interface TableDefinition { | ||
| cluster?: pb.Schema['cluster']; | ||
| keyspace?: pb.Schema['keyspace']; | ||
| // The [0] index is a typescript quirk to infer the type of |
Contributor
There was a problem hiding this comment.
TIL! (thank you for commenting!)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sara Bee 855595+doeg@users.noreply.github.com
Description
✨ Staged at http://vtadmin.puppy.software
Adds routes and (very ugly) simple tables for all of the entity routes (clusters, gates, keyspaces, schemas, and tablets). Most of these don't look very interesting yet.
Related Issue(s)
Checklist
Deployment Notes
See above.
Impacted Areas in Vitess
Components that this PR will affect: