Validate SrvKeyspace during Reshard/SwitchReads#7481
Merged
rohit-nayak-ps merged 6 commits intovitessio:masterfrom Feb 19, 2021
Merged
Validate SrvKeyspace during Reshard/SwitchReads#7481rohit-nayak-ps merged 6 commits intovitessio:masterfrom
rohit-nayak-ps merged 6 commits intovitessio:masterfrom
Conversation
deepthi
approved these changes
Feb 18, 2021
Collaborator
deepthi
left a comment
deepthi
left a comment
There was a problem hiding this comment.
One minor suggestion on error message.
Otherwise LGTM.
rohit-nayak-ps
force-pushed
the
rn-reshard-validate-srvkeyspace
branch
from
808f1bc to
5be8f23
Compare
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
rohit-nayak-ps
force-pushed
the
rn-reshard-validate-srvkeyspace
branch
from
5be8f23 to
58b8028
Compare
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rohit Nayak rohit@planetscale.com
Description
There have been a few reports where SwitchReads fail with a
keyspace partition for MASTER in cell xxxx does not start with min keyerror. This error happens when the SrvKeyspace is inconsistent. This PR adds validations to check that the SrvKeyspace is consistent while creating a workflow and before and after workflow state changes. Hopefully if there is a bug these checks and added logs will help surface it, or it will alert the user in case the SrvVSchema was not consistent before invoking a vrep command.Checklist
Impacted Areas in Vitess
Components that this PR will affect: