add combine TLS certs feature#7609
Merged
deepthi merged 1 commit intovitessio:masterfrom Mar 10, 2021
Merged
Conversation
eselyavka
requested review from
deepthi,
harshit-gangal and
systay
as code owners
deepthi
reviewed
Mar 4, 2021
deepthi
reviewed
Mar 4, 2021
deepthi
reviewed
Mar 4, 2021
Collaborator
deepthi
left a comment
deepthi
left a comment
There was a problem hiding this comment.
I have some comments, but we'll need a more thorough review from one of the others.
eselyavka
force-pushed
the
eseliavka/7608
branch
2 times, most recently
from
0037680 to
136465b
Compare
Member
|
While we review your PR, could you please remove the issue id MVP-53256 from the commit message. This looks unrelated to Vitess Github Issue. |
eselyavka
force-pushed
the
eseliavka/7608
branch
from
136465b to
a3de08e
Compare
eselyavka
changed the title
Contributor
Author
|
Collaborator
|
Can you resolve the merge conflicts? Please choose the |
Signed-off-by: Evgenii Seliavka <eseliavka@twitter.com>
eselyavka
force-pushed
the
eseliavka/7608
branch
from
a3de08e to
3df553c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Certificate chain (or Chain of Trust) is made up of a list of certificates that start from a server's certificate and terminate with the root certificate. If your server's certificate is to be trusted, its signature has to be traceable back to its root CA. However in case of Vitess we cannot see the full list of certificates. The change is to pass the full list of certs.
Related Issue(s)
#7608
Checklist
Deployment Notes
Tested in my local env.
Impacted Areas in Vitess
Components that this PR will affect: