VReplication DryRun: Report current dry run results for v2 commands#7255
Merged
rohit-nayak-ps merged 3 commits intovitessio:masterfrom Jan 19, 2021
Merged
VReplication DryRun: Report current dry run results for v2 commands#7255rohit-nayak-ps merged 3 commits intovitessio:masterfrom
rohit-nayak-ps merged 3 commits intovitessio:masterfrom
Conversation
rohit-nayak-ps
requested review from
ajm188,
deepthi,
doeg and
sougou
as code owners
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
rohit-nayak-ps
force-pushed
the
rn-v2-dry-run
branch
from
e91e9f2 to
d62b5a5
Compare
ajm188
approved these changes
Jan 15, 2021
Contributor
ajm188
left a comment
ajm188
left a comment
There was a problem hiding this comment.
very minor helptext change, otherwise lg2m
go/vt/vtctl/vtctl.go
Outdated
| cells := subFlags.String("cells", "", "Cell(s) or CellAlias(es) (comma-separated) to replicate from.") | ||
| tabletTypes := subFlags.String("tablet_types", "", "Source tablet types to replicate from (e.g. master, replica, rdonly). Defaults to -vreplication_tablet_type parameter value for the tablet, which has the default value of replica.") | ||
| tabletTypes := subFlags.String("tablet_types", "master,replica,rdonly", "Source tablet types to replicate from (e.g. master, replica, rdonly). Defaults to -vreplication_tablet_type parameter value for the tablet, which has the default value of replica.") | ||
| dryRun := subFlags.Bool("dry_run", false, "Does a dry run of SwitchReads and only reports the actions to be taken") |
Contributor
There was a problem hiding this comment.
This help should be updated to reflect line 2146
Member
Author
There was a problem hiding this comment.
fixed, thanks for pointing out!
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
rohit-nayak-ps
added a commit
that referenced
this pull request
Jan 22, 2021
Backport #7255: VReplication DryRun: Report current dry run results for v2 commands
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rohit Nayak rohit@planetscale.com
Description
Related Issue(s)
#7071
Checklist
Impacted Areas in Vitess
Components that this PR will affect: