VReplication: error out if binlog compression is turned on#7670
Merged
rohit-nayak-ps merged 1 commit intovitessio:masterfrom Mar 15, 2021
Merged
VReplication: error out if binlog compression is turned on#7670rohit-nayak-ps merged 1 commit intovitessio:masterfrom
rohit-nayak-ps merged 1 commit intovitessio:masterfrom
Conversation
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
shlomi-noach
approved these changes
Mar 14, 2021
Contributor
shlomi-noach
left a comment
There was a problem hiding this comment.
LGTM even though still in "draft"
Member
Author
Thanks! I was waiting for tests to complete and forgot to move it from Draft. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The binlog streamer does not handle the
transaction_payload_event, which is sent when binlog compression is used. Currently these events were being silently dropped by VReplication. The copy phase succeeds, but no events are processed while replicating and no error is reported.With this PR, the VStreamer will error out if it detects binlog compression so that it is reported back to the user. The output of
Workflow Showwould display something like:See related issue for discussions around this.
Signed-off-by: Rohit Nayak rohit@planetscale.com
Related Issue(s)
Checklist
Impacted Areas in Vitess
Components that this PR will affect: