Skip to content

VReplication: error out if binlog compression is turned on#7670

Merged
rohit-nayak-ps merged 1 commit intovitessio:masterfrom
planetscale:rn_binlog_compression
Mar 15, 2021
Merged

VReplication: error out if binlog compression is turned on#7670
rohit-nayak-ps merged 1 commit intovitessio:masterfrom
planetscale:rn_binlog_compression

Conversation

@rohit-nayak-ps
Copy link
Member

@rohit-nayak-ps rohit-nayak-ps commented Mar 12, 2021

Description

The binlog streamer does not handle the transaction_payload_event, which is sent when binlog compression is used. Currently these events were being silently dropped by VReplication. The copy phase succeeds, but no events are processed while replicating and no error is reported.

With this PR, the VStreamer will error out if it detects binlog compression so that it is reported back to the user. The output of Workflow Show would display something like:

                                        "Pos": "MySQL56/963a4ef5-8333-11eb-a12a-04ed332e05c2:1-42",
					"StopPos": "",
					"State": "Error",
					"DBName": "vt_customer",
					"TransactionTimestamp": 1615554393,
					"TimeUpdated": 1615554417,
					"Message": "Error: vttablet: rpc error: code = Unknown desc = stream (at source tablet) error @ 963a4ef5-8333-11eb-a12a-04ed332e05c2:1-43: VReplication does not handle binlog compression",
					"CopyState": null

See related issue for discussions around this.

Signed-off-by: Rohit Nayak rohit@planetscale.com

Related Issue(s)

Checklist

  • Should this PR be backported?
  • Tests were added or are not required
  • Documentation was added or is not required

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build/CI
  • VTAdmin

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps rohit-nayak-ps requested review from a team and sougou March 12, 2021 16:07
Copy link
Contributor

@shlomi-noach shlomi-noach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM even though still in "draft"

@rohit-nayak-ps rohit-nayak-ps marked this pull request as ready for review March 15, 2021 07:17
@rohit-nayak-ps rohit-nayak-ps merged commit ffb5d4d into vitessio:master Mar 15, 2021
@rohit-nayak-ps rohit-nayak-ps deleted the rn_binlog_compression branch March 15, 2021 07:18
@rohit-nayak-ps
Copy link
Member Author

LGTM even though still in "draft"

Thanks! I was waiting for tests to complete and forgot to move it from Draft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants