Fixes ordering in SELECT INTO and printing of strings#7655
Merged
systay merged 6 commits intovitessio:masterfrom Mar 15, 2021
Merged
Fixes ordering in SELECT INTO and printing of strings#7655systay merged 6 commits intovitessio:masterfrom
systay merged 6 commits intovitessio:masterfrom
Conversation
Signed-off-by: GuptaManan100 <manan@planetscale.com>
Signed-off-by: GuptaManan100 <manan@planetscale.com>
Signed-off-by: GuptaManan100 <manan@planetscale.com>
systay
reviewed
Mar 10, 2021
systay
approved these changes
Mar 10, 2021
Signed-off-by: GuptaManan100 <manan@planetscale.com>
Signed-off-by: GuptaManan100 <manan@planetscale.com>
Signed-off-by: GuptaManan100 <manan@planetscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The query
select * from t1 into outfile '/tmp/foo.csv' fields escaped by '\\' terminated by '\n';works on MySQL but was failing on Vitess. This is because we were parsing strings with escape characters but were not emitting it correctly, i.e.'\\'gets converted to'\'. This PR fixes this issue. Also, any ordering ofTERMINATED BY, ENCLOSED BY and ESCAPED BYis permitted in MySQL. This is also addressed in this PR.Checklist
Impacted Areas in Vitess
Components that this PR will affect: