Skip to content

fix common select script to work for both local and operator examples#7348

Merged
rohit-nayak-ps merged 1 commit intovitessio:masterfrom
planetscale:ds-fix-use-commerce
Jan 23, 2021
Merged

fix common select script to work for both local and operator examples#7348
rohit-nayak-ps merged 1 commit intovitessio:masterfrom
planetscale:ds-fix-use-commerce

Conversation

@deepthi
Copy link
Copy Markdown
Collaborator

@deepthi deepthi commented Jan 22, 2021

Signed-off-by: deepthi deepthi@planetscale.com

Description

In #7245 we removed a file (select_commerce_data.sql) from the operator example. However, the README still points to the deleted file.
This PR fixes the README to use the correct path to the file.
In addition, the use command in that file only worked for the local example, not the operator example.
That has also been fixed.

Related Issue(s)

#7245
A website PR will be created after 9.0 is released and we have archived the 9.0 docs.

Checklist

  • Should this PR be backported?
  • Tests were added or are not required
  • Documentation was added or is not required

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build
  • VTAdmin

Signed-off-by: deepthi <deepthi@planetscale.com>
@deepthi deepthi requested a review from sougou as a code owner January 22, 2021 21:09
@deepthi deepthi requested a review from askdba January 22, 2021 21:10
Copy link
Copy Markdown
Member

@rohit-nayak-ps rohit-nayak-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rohit-nayak-ps rohit-nayak-ps merged commit a346fb7 into vitessio:master Jan 23, 2021
@rohit-nayak-ps rohit-nayak-ps deleted the ds-fix-use-commerce branch January 23, 2021 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants