Fixes function call in default value of a column in CREATE TABLE statement#8425
Merged
systay merged 5 commits intovitessio:release-9.0from Jul 8, 2021
Merged
Conversation
harshit-gangal
approved these changes
Jul 7, 2021
frouioui
reviewed
Jul 7, 2021
Member
|
e2e tests are failing |
Signed-off-by: GuptaManan100 <manan@planetscale.com>
Signed-off-by: GuptaManan100 <manan@planetscale.com>
Signed-off-by: GuptaManan100 <manan@planetscale.com>
8daa823 to
4005fb1
Compare
Signed-off-by: GuptaManan100 <manan@planetscale.com>
Signed-off-by: GuptaManan100 <manan@planetscale.com>
systay
approved these changes
Jul 8, 2021
2 tasks
ajm188
pushed a commit
to tinyspeck/vitess
that referenced
this pull request
Jul 18, 2021
git seemed to not apply this change after the formatting functions got moved from `ast.go` to `ast_format.go` Signed-off-by: Andrew Mason <amason@slack-corp.com>
ajm188
pushed a commit
to tinyspeck/vitess
that referenced
this pull request
Jul 19, 2021
Signed-off-by: Andrew Mason <amason@slack-corp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes function call in default value of a column in CREATE TABLE statement. The function calls must be parenthesised according to the syntax.
Related Issue(s)
Checklist