make sure to add necessary bindvars when preparing queries#7493
Merged
systay merged 1 commit intovitessio:masterfrom Feb 16, 2021
Merged
make sure to add necessary bindvars when preparing queries#7493systay merged 1 commit intovitessio:masterfrom
systay merged 1 commit intovitessio:masterfrom
Conversation
Signed-off-by: Andres Taylor <andres@planetscale.com>
harshit-gangal
approved these changes
Feb 16, 2021
Comment on lines
+2187
to
+2191
| sql := "select database()" | ||
| _, err := executorPrepare(executor, sql, map[string]*querypb.BindVariable{}) | ||
| require.NoError(t, err) | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
nit: could assert that the bindvars were added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7379
Some queries need extra bindvars injected before executing. The error here was that for the field type query during
PREPARE, we were not setting all the required bindvars.Signed-off-by: Andres Taylor andres@planetscale.com