Make dependency install a bit more robust#7260
Merged
dkhenry merged 2 commits intovitessio:masterfrom Jan 9, 2021
Merged
Conversation
Make sure networking hicup's don't stop the build, and protect against an common dependency issue with deb not installing mysql-server Signed-off-by: D.K <dan.kozlowski@gmail.com>
deepthi
approved these changes
Jan 7, 2021
Collaborator
deepthi
left a comment
deepthi
left a comment
There was a problem hiding this comment.
LGTM. I assume you tested locally :)
Signed-off-by: D.K <dan.kozlowski@gmail.com> Signed-off-by: D.K. <dan.kozlowski@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make docker build a bit more robust
Related Issue(s)
Checklist
Impacted Areas in Vitess
Components that this PR will affect: