Fix for transactions not allowed to finish during PlannedReparentShard#8099
Merged
harshit-gangal merged 1 commit intovitessio:release-10.0from May 12, 2021
Merged
Fix for transactions not allowed to finish during PlannedReparentShard#8099harshit-gangal merged 1 commit intovitessio:release-10.0from
harshit-gangal merged 1 commit intovitessio:release-10.0from
Conversation
Backport of vitessio#8089 This is a combination of 3 commits. * remove precheck of tablet serving and target * remove the additional logic and return error if queryservice not found to serve query * fix test as per new change Signed-off-by: Harshit Gangal <harshit@planetscale.com> Signed-off-by: Andres Taylor <andres@planetscale.com>
harshit-gangal
approved these changes
May 12, 2021
deepthi
reviewed
May 13, 2021
Comment on lines
+568
to
+572
| // ChangeTabletType changes the tablet type. | ||
| func (sbc *SandboxConn) ChangeTabletType(typ topodatapb.TabletType) { | ||
| sbc.tablet.Type = typ | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
Where is this being used?
systay
changed the title
systay
changed the title
deepthi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If PRS is going on, then Query serving will fail with the recent change in reserved connection fix. Before sending to tablet there was check introduce to see if the tablet is serving and the target has not changed then send the query to vttablet.
This is not true for transaction as we want the query which is in transaction to be sent down to get the transaction completed, also the PRS is waiting for any outstanding transaction to get completed.
So, this change is to remove the logic around it and the reserved connection will reset the shard session only when the error is received from the vttablet and there is no pre-check for it.
This is a combination of 3 commits.
Related Issue(s)
Backport of #8089