Skip to content

chore: gitops-engine migration#24710

Merged
leoluz merged 371 commits intoargoproj:masterfrom
leoluz:gitops-migration
Sep 24, 2025
Merged

chore: gitops-engine migration#24710
leoluz merged 371 commits intoargoproj:masterfrom
leoluz:gitops-migration

Conversation

@leoluz
Copy link
Collaborator

@leoluz leoluz commented Sep 23, 2025

dependabot bot and others added 30 commits August 28, 2020 13:28
Bumps [actions/setup-go](https://github.com/actions/setup-go) from v2.1.1 to v2.1.2.
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](actions/setup-go@v2.1.1...8a3a76c)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
- print using test logger
- print using fmt - println use is discouraged
…oproj#120)

Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from v1.0.12 to v1.0.13.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Commits](codecov/codecov-action@v1.0.12...6004246)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
argoproj#136)

* fix: health status is set to healthy for statefulset with updateStrategy: OnDelete

* fix: updated message

* fix: added test
…oj#137)

* fix: health status is set to healthy for statefulset with updateStrategy: OnDelete

* fix: updated message

* fix: added test

* fix: health status for daemon set with Ondelete updateStrategy
argoproj#141)

* fix: Support transition from a git managed namespace to auto-create namespace

* fix: Support transition from a git managed namespace to auto-create namespace

* fix: use sync task to remove label

* fix: withNamespaceCreation

* fix: fix failed test

* fix: remove obsolete comment.
argoproj#144)

* fix: Hook Deletion Policies HookSucceeded should be run after whole Hook succeed and not only Resource succeed

* fix: handle HookFailed.

* fix: fixing lint error.
Bumps [actions/setup-go](https://github.com/actions/setup-go) from v2.1.2 to v2.1.3.
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](actions/setup-go@v2.1.2...37335c7)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…oj#173)

Bumps [github.com/go-logr/logr](https://github.com/go-logr/logr) from 0.2.0 to 0.2.1.
- [Release notes](https://github.com/go-logr/logr/releases)
- [Commits](go-logr/logr@v0.2.0...v0.2.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…nc wave (argoproj#177)

Signed-off-by: Jesse Suen <jesse_suen@intuit.com>
Signed-off-by: Mikhail Mazurskiy <mmazurskiy@gitlab.com>
…#180)

Signed-off-by: yutachaos <18604471+yutachaos@users.noreply.github.com>
…me hooks properly (argoproj#183)

Signed-off-by: Jesse Suen <jessesuen@gmail.com>
* panic: interface conversion: interface {} is string

Signed-off-by: May Zhang <may_zhang@intuit.com>
…rgoproj#190)

* fix: HPA health check is making incorrect assumption on annotations

Signed-off-by: May Zhang <may_zhang@intuit.com>

* fix: added handle of v1, v2beta1 and v2beta2

Signed-off-by: May Zhang <may_zhang@intuit.com>

* fix: clean up test data file

Signed-off-by: May Zhang <may_zhang@intuit.com>
…proj#194)

Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from v1.0.13 to v1.1.0.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/master/CHANGELOG.md)
- [Commits](codecov/codecov-action@v1.0.13...7de43a7)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
pjiang-dev and others added 15 commits June 17, 2025 13:49
Signed-off-by: Peter Jiang <peterjiang823@gmail.com>
* chore: Cleanup IterateHierarchy v1

Part of argoproj#23854

Remove the unused code in gitops-engine.

Signed-off-by: Andrii Korotkov <myolymp@gmail.com>

* Revert some deleted tests

Signed-off-by: Andrii Korotkov <myolymp@gmail.com>

---------

Signed-off-by: Andrii Korotkov <myolymp@gmail.com>
…rgoproj#747)

* WIP fix: update normalization for ignoreDifferences on server-side diff

Signed-off-by: Peter Jiang <peterjiang823@gmail.com>

* fix linter

Signed-off-by: Peter Jiang <peterjiang823@gmail.com>

* refactor

Signed-off-by: Peter Jiang <peterjiang823@gmail.com>

* skip pre-normalization for ssd

Signed-off-by: Peter Jiang <peterjiang823@gmail.com>

* skip pre-normalization for ssd

Signed-off-by: Peter Jiang <peterjiang823@gmail.com>

* docs

Signed-off-by: Peter Jiang <peterjiang823@gmail.com>

* modify Normalize to skip ignoreDifferences conditionally

Signed-off-by: Peter Jiang <peterjiang823@gmail.com>

* ignoreDifferences for SSD and test backwards compatible

Signed-off-by: Peter Jiang <peterjiang823@gmail.com>

* rename flags for clarity

Signed-off-by: Peter Jiang <peterjiang823@gmail.com>

* doc change

Signed-off-by: Peter Jiang <peterjiang823@gmail.com>

---------

Signed-off-by: Peter Jiang <peterjiang823@gmail.com>
Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
Signed-off-by: rafal-jan <rafal7jan@gmail.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
…oj#770)

* fix(hooks): always remove finalizers

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>

* unit test

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>

---------

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
argoproj#766)

* Adds a script to prepare repo for migration to main ArgoCD Repo

Signed-off-by: Patroklos Papapetrou <ppapapetrou76@gmail.com>

* remove also .gitignore

Signed-off-by: Patroklos Papapetrou <ppapapetrou76@gmail.com>

* fix script

Signed-off-by: Patroklos Papapetrou <ppapapetrou76@gmail.com>

* address pr comments

Signed-off-by: Patroklos Papapetrou <ppapapetrou76@gmail.com>

---------

Signed-off-by: Patroklos Papapetrou <ppapapetrou76@gmail.com>
…uster scoped resources (argoproj#765)

* Using live obj to get the resource key if not nil

Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com>

* Fixed failing unit tests

Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com>

* Added test case for validating cluster scoped resources with ApplyOutOfSyncOnly=true

Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com>

* Fixed gofumpt formatting errors

Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com>

* Corrected unit tests for cluster scoped resources

Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com>

* Removed unwanted code comments

Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com>

* Added comments for explaining the reason why ns is set from live object

Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com>

* Added comments in the unit test

Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com>

---------

Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com>
* bump k8s v1.34

Signed-off-by: Peter Jiang <peterjiang823@gmail.com>

* fix broken dependencies

Signed-off-by: Peter Jiang <peterjiang823@gmail.com>

---------

Signed-off-by: Peter Jiang <peterjiang823@gmail.com>
Signed-off-by: Patroklos Papapetrou <ppapapetrou76@gmail.com>
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
@leoluz leoluz requested review from a team as code owners September 23, 2025 14:16
@bunnyshell
Copy link

bunnyshell bot commented Sep 23, 2025

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@codecov
Copy link

codecov bot commented Sep 23, 2025

Codecov Report

❌ Patch coverage is 62.12509% with 1629 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.69%. Comparing base (452f6c6) to head (f20995b).
⚠️ Report is 785 commits behind head on master.

Files with missing lines Patch % Lines
gitops-engine/pkg/diff/diff.go 45.99% 354 Missing and 84 partials ⚠️
gitops-engine/pkg/cache/cluster.go 69.36% 221 Missing and 52 partials ⚠️
gitops-engine/pkg/sync/sync_context.go 81.76% 154 Missing and 53 partials ⚠️
gitops-engine/pkg/health/health_hpa.go 0.00% 120 Missing ⚠️
...ff/internal/fieldmanager/borrowed_managedfields.go 28.18% 102 Missing and 5 partials ⚠️
gitops-engine/pkg/health/health_statefulset.go 0.00% 55 Missing ⚠️
...nal/kubernetes_vendor/pkg/api/v1/endpoints/util.go 0.00% 42 Missing ⚠️
gitops-engine/pkg/health/health_apiservice.go 30.18% 36 Missing and 1 partial ⚠️
gitops-engine/pkg/cache/references.go 50.70% 34 Missing and 1 partial ⚠️
gitops-engine/pkg/cache/resource.go 38.88% 32 Missing and 1 partial ⚠️
... and 18 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #24710      +/-   ##
==========================================
+ Coverage   60.51%   60.69%   +0.17%     
==========================================
  Files         350      404      +54     
  Lines       60196    66091    +5895     
==========================================
+ Hits        36430    40114    +3684     
- Misses      20832    22721    +1889     
- Partials     2934     3256     +322     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leoluz leoluz changed the title gitops migration chore: gitops migration test Sep 23, 2025
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
@ranakan19
Copy link
Member

I saw #24293 was closed — is this intended as the replacement? I’m asking because I have a PR currently blocked by the migration and want to make sure I’m tracking the right one.

@leoluz
Copy link
Collaborator Author

leoluz commented Sep 23, 2025

is this intended as the replacement?

@ranakan19 Yes. This is the last testing PR before we create the official one.

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
@leoluz leoluz changed the title chore: gitops migration test chore: gitops-engine migration Sep 24, 2025
@leoluz
Copy link
Collaborator Author

leoluz commented Sep 24, 2025

⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️
PLEASE DO NOT SQUASH DURING MERGE AS WE WANT TO PRESERVE THE GIT HISTORY
⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️

(Sorry for the caps. Just wanted to make sure that I got your attention 😄 )

@leoluz leoluz merged commit 6dee3d6 into argoproj:master Sep 24, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.