Use gRPC error codes instead of fmt.Errorf#532
Merged
merenbach merged 1 commit intoargoproj:masterfrom Aug 28, 2018
merenbach:512-better-error-codes
Merged
Use gRPC error codes instead of fmt.Errorf#532merenbach merged 1 commit intoargoproj:masterfrom merenbach:512-better-error-codes
merenbach merged 1 commit intoargoproj:masterfrom
merenbach:512-better-error-codes
Conversation
jessesuen
approved these changes
Aug 28, 2018
leoluz
pushed a commit
to leoluz/argo-cd
that referenced
this pull request
Sep 29, 2023
* feat: respect rbac for resource exclusions Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> * feat: use list call to check for permissions Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> * feat: updated implementation to handle different levels of rbac check Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> * feat: fixed linter error Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> * feat: resolve review comments Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> --------- Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #512
Output with this patch when adding, for instance, an app at an invalid path, yielding an embedded
FailedPreconditionerror code:Before the patch, the embedded error has a code of
Unknown: